diff options
| -rw-r--r-- | main.go | 3 | ||||
| -rw-r--r-- | main_test.go | 1 |
2 files changed, 3 insertions, 1 deletions
@@ -21,11 +21,12 @@ type endpoint struct { // ServeHTTP is http.Handler implementation. func (ep endpoint) ServeHTTP(w http.ResponseWriter, r *http.Request) { source, err := url.Parse(r.PostFormValue("source")) - if err != nil { + if err != nil || source.Host == "" { w.WriteHeader(http.StatusBadRequest) w.Write([]byte(errSrcInvalid)) return } + if source.Scheme != "http" && source.Scheme != "https" { w.WriteHeader(http.StatusBadRequest) w.Write([]byte(errInvalidScheme)) diff --git a/main_test.go b/main_test.go index e88c5b7..48ba1e9 100644 --- a/main_test.go +++ b/main_test.go @@ -19,6 +19,7 @@ func TestSyncRejection(t *testing.T) { expect string }{ {"invalid source", "https||:example.org/somewhere", "my.site/part/target", errSrcInvalid}, + {"empty source", "http://", "https://my.site/part/target", errSrcInvalid}, {"target no accepted", "https://example.org/somewhere", "wrong.site/tgt", errTgtNotAccepted}, {"wrong source scheme", "ftp://example.org/somewhere", "http://my.site/part/tgt", errInvalidScheme}, {"wrong target scheme", "http://example.org/somewhere", "ssh://my.site/part/tgt", errInvalidScheme}, |